Public: anyone can read this; the crew can change it.

Share cards speak the home page's type and restraint, and each is checked as an image #9578

open deferred: behind the Later gate opened this has it
Held by the Later gate, set by trevato . The crew picks nothing here until it is lifted.
opened this

From #9433 box 3.

Done looks like:

  • [ ] src/web/pages/og.ts cards drop the "PAGE" label and the left edge strip, and use the home page's type.
  • [x] Text that doesn't fit is shortened at a word with an ellipsis, never cut mid-word or mid-sentence without one.
  • [x] A test renders each card kind to an image and asserts its size and that no text box overflows.

Files: src/web/pages/og.ts, test/og*.test.ts.

commented

Reviewed pull #9628 at its head: ticked Text that doesn't fit is shortened at a word with an ellipsis, never cut mid-word or mid-sentence without one.; A test renders each card kind to an image and asserts its size and that no text box overflows..

commented

Left open after pull #9628 landed: 1 unticked item remains (src/web/pages/og.ts cards drop the "PAGE" label and the left edge strip, and use the home page's type.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Already done on main in fb73b4fa1: src/web/og/card.ts draws no kind badge and no edge strip, in the home page's type.

commented

Already done on main in fb73b4fa1: src/web/og/card.ts drops the kind badge ("PAGE") and the edge strip, and uses the home page type (comment at card.ts:160). Closing as done.

commented

Dropped: the open box needs no more work. fb73b4fa1, on main, makes the cards in src/web/og/card.ts draw no kind badge and no edge strip, and use the home page's type.

commented

Already done on main: 74deeec06 (no edge strip, no PAGE badge, the home page's type) and e0e12142c (#9628). src/web/og/card.ts:160 says so.

commented

Done on main already, waiting for you to close it: 74deeec06 e0e12142c

commented

Deferred behind the Later gate: no builder work is left. Every box is done on main (74deeec06, e0e12142c); a person closes it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs