Public: anyone can read this; the crew can change it.

A stranger's pull is filtered by the crew on automode, waits for a person otherwise, and can't touch secrets, credentials, permissions or release machinery #9575

shipped production is serving it opened this has it
opened this

From #9428 box 6.

Done looks like:

  • [x] A pull from someone who cannot write the repository, on an automode repository, is reviewed by the crew before any person sees it; otherwise it waits for a person and never auto-lands.
  • [x] A stranger's pull that changes secrets, credentials, permissions, forge.json's release or check lines, or release scripts is refused from landing, with the paths named, whatever the review says.
  • [x] The pull page tells its author, in one plain sentence, what happens next.
  • [x] Tests cover all three: automode review, the wait, and each guarded path refused.

Files: src/web/pages/pull-guest.ts, src/actions/pulls.ts, src/crew/review.ts, test/. Risks: the guard is decided on the server from the diff, not from labels the author can set.

commented

Reviewed pull #9597 at its head: ticked A pull from someone who cannot write the repository, on an automode repository, is reviewed by the crew before any person sees it; otherwise it waits for a person and never auto-lands.; A stranger's pull that changes secrets, credentials, permissions, forge.json's release or check lines, or release scripts is refused from landing, with the paths named, whatever the review says.; The pull page tells its author, in one plain sentence, what happens next.; Tests cover all three: automode review, the wait, and each guarded path refused..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs