Public: anyone can read this; the crew can change it.

Absorb: finding and removing a feature, and how the menu shows one #9544

Closed opened this has it

Landed in pull #9644 · run

opened this

Found in the Experience review of #9441 (read from src/web/pages/features.ts, src/web/layout.ts).

  • An admin finds Absorb only at Settings > Features. Nothing on an app's own page says the app declares a feature; the empty state explains the block but links no docs (docs/features/absorb.md).
  • Absorb and Un-absorb are one button, with no preview: absorbing redeploys the app, un-absorbing removes the entry from every reader's menu. The flash says so only afterwards.
  • A refused save shows one flash and re-renders from stored values, so what the admin typed is lost and no field is marked.
  • A person meets a feature as one more menu line with the generic rocket icon among the forge's own links; the declared summary is never shown outside Settings.
  • The settings kit is used as is; it is not yet in the home page's design language (#9433).

Change:

Files: src/web/pages/features.ts, src/web/layout.ts, src/web/pages/apps.ts.

2 earlier comments
commented

Reviewed pull #9644 at its head: ticked A line before Absorb/Un-absorb saying what restarts and who gains or loses an entry.; Keep typed values on a refused save and mark the field.. left open: Link "Features" from the page of an app that declares one (admin only); link the docs from the empty state. — The link shows only on absorbed apps, not on any app that declares a feature; the docs link from the empty state is done.; Show summary as the menu entry's title. — Removed because the tooltip pushed pages over the byte budgets in pull-quiet; the summary shows on the Features page only.; Re-skin to the home page's language once #9433 lands; name new classes in docs/design/areas/features.md. — Not done; waits on #9433..

commented

Left open after pull #9644 landed: 3 unticked items remain (Link "Features" from the page of an app that declares one (admin only); link the docs from the empty state.; Show summary as the menu entry's title.; Re-skin to the home page's language once #9433 lands; name new classes in docs/design/areas/features.md.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Split: the shipped work stays; each open box is now its own issue: #9680 (Features link on a declaring app's page, docs link on the empty state), #9681 (the menu entry's title is the declared summary), #9682 (Settings › Features in the home page's language, classes in docs/design/areas/features.md).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs