Public: anyone can read this; the crew can change it.

Absorb: Settings > Features and /api/v1/features read git for every app on every request #9543

shipped production is serving it opened this has it

Landed in pull #9650 · 2 runs · run

opened this

Found in the Speed review of #9441.

listFeatures (src/actions/features.ts) walks every app and reads forge.json from git at its default tip, on each load of /settings/features, GET /api/v1/features and the features MCP list. Fine for a handful of apps (the code says so); linear git work on a forge with hundreds. Also, every page for a signed-in person runs absorbedForNav: one listAbsorbed plus getAppById, getRepoById and canRead per absorbed app, and featureItems fetches the app record a second time. Cheap with two features, linear with many; not measured yet. A menu click on a sleeping app wakes it through /apps/open with no sign of that.

Change:

Files: src/actions/features.ts, src/web/layout.ts.

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

Reviewed pull #9650 at its head: ticked Cache the parsed declaration by default-branch tip oid, so the list reads git only for apps whose tip moved.; absorbedForNav returns the record it already fetched; featureItems stops re-reading it.; A test with 20 absorbed apps asserts the menu render stays within a stated budget (route-timing phases exist)..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs