Public: anyone can read this; the crew can change it.
Absorb: deleting an app leaves its feature rows and settings behind #9542
commented
Reviewed pull #9643 at its head: ticked deleteApp deletes both tables' rows for the app in the same transaction.; Test in test/features.test.ts: absorb, set a value, delete the app; neither table holds a row for its id..
Sign in to join this conversation.
new above
offline
Found in the Security review of #9441.
deleteApp(src/core/apps.ts) removesapp_vitaland the app, but notapp_featureorapp_feature_setting(no foreign key, no cleanup). Settings are plain values kept across un-absorb by design; after the app is gone they stay in the database for nothing, and the nav silently skips the orphan.Change:
Files: src/core/apps.ts, test/features.test.ts.