Public: anyone can read this; the crew can change it.

Absorb: deleting an app leaves its feature rows and settings behind #9542

shipped production is serving it opened this has it

Landed in pull #9643 · run

opened this

Found in the Security review of #9441.

deleteApp (src/core/apps.ts) removes app_vital and the app, but not app_feature or app_feature_setting (no foreign key, no cleanup). Settings are plain values kept across un-absorb by design; after the app is gone they stay in the database for nothing, and the nav silently skips the orphan.

Change:

Files: src/core/apps.ts, test/features.test.ts.

commented

Reviewed pull #9643 at its head: ticked deleteApp deletes both tables' rows for the app in the same transaction.; Test in test/features.test.ts: absorb, set a value, delete the app; neither table holds a row for its id..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs