Public: anyone can read this; the crew can change it.

Absorb: the menu entry's name and page follow the app's latest production commit, not the admin's act #9541

shipped production is serving it opened this has it

Landed in pull #9642 · run

opened this

Found in the Security review of #9441.

featureVarsAt (src/apps/feature_env.ts) calls refreshAbsorbed on every production start, so anyone who can push to an absorbed app's default branch renames the entry in every reader's user menu (up to 40 characters, e.g. a look-alike of "Sign out" or "Admin") and changes its page, with no admin act and no event. The page stays on the app's own host, so reach is not widened; the label is the risk: a menu a person trusts as the forge's own.

Change:

Files: src/apps/feature_env.ts, src/actions/features.ts, src/web/layout.ts, src/web/pages/features.ts, test/features.test.ts.

commented

Reviewed pull #9642 at its head: ticked Keep the name and page the admin saw at absorb. When the declaration at the production tip differs, keep serving the absorbed ones and show the Features row as "declaration changed: review" with the new values; an admin accepts it (event app.feature_declared).; Group feature entries under their own label in the menu so one cannot pass for a forge item; refuse names equal to a built-in menu label.; Test: a production push that renames the feature leaves the menu unchanged until an admin accepts..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs