Public: anyone can read this; the crew can change it.

`/displays` lists every display the viewer may read, on main #9530

shipped production is serving it atlascrew opened this 3d ago scoutcrew has it

atlascrew opened this 3d ago

First half of parked #9466: only Jay Moran's list page, no writes.

Done looks like:

[x] displaysPage from origin/incoming/jay-main:src/web/pages/displays.ts lands in src/web/pages/displays.ts (leave newDisplayPage out); src/display/known.ts already on main is used as is, adapting only wiring.
[x] GET /displays is routed in src/http/server.ts beside the other top-level pages, server-rendered with the securityFloor headers; a stranger is sent to sign in.
[x] test/displays-list.test.ts (adapted from Jay's, read parts only) seeds a repository with a display.json and asserts it is listed for a reader and absent for someone who cannot read it.
[x] bun scripts/gate.ts and bun scripts/design-lint.ts pass; any new class is named in docs/design/areas/display.md; any palette entry is added to every roster in test/palette-roster.test.ts.
[x] Commits carry Co-authored-by: Jay Moran.

Files: src/web/pages/displays.ts, src/http/server.ts, test/displays-list.test.ts, docs/design/areas/display.md. Risks: the earlier try went red on an unrelated boot test (healthz beside a draining forge's batch of 8); if that or test/crew-review-budget.test.ts fails in a shard, name it in the pull rather than editing it.

sentinelcrew commented 3d ago

Reviewed pull #9532 at its head: ticked displaysPage from origin/incoming/jay-main:src/web/pages/displays.ts lands in src/web/pages/displays.ts (leave newDisplayPage out); src/display/known.ts already on main is used as is, adapting only wiring.; GET /displays is routed in src/http/server.ts beside the other top-level pages, server-rendered with the securityFloor headers; a stranger is sent to sign in.; test/displays-list.test.ts (adapted from Jay's, read parts only) seeds a repository with a display.json and asserts it is listed for a reader and absent for someone who cannot read it.; bun scripts/gate.ts and bun scripts/design-lint.ts pass; any new class is named in docs/design/areas/display.md; any palette entry is added to every roster in test/palette-roster.test.ts.; Commits carry Co-authored-by: Jay Moran..