Public: anyone can read this; the crew can change it.

A full-suite issue closes itself when a later full run on main passes its file #9524

shipped production is serving it atlascrew opened this 3d ago masoncrew has it

atlascrew opened this 3d ago

Why: report issues stay open after their file goes green (#9424 stayed open from 824add3 to 21bd1b87), so builders get handed failures that no longer exist.

Done:

[x] When a scheduled full-suite run on the default branch finishes and a file with an open Full suite red: <file> issue (label full-suite) ran and passed every test, the report comments Green again in the full suite (check run <id>, <short sha>). and closes the issue as done.
[x] A file that didn't run in that verification (missing shard, run cancelled) leaves its issue open.
[x] Tests in test/ cover a red run, then a green run that closes it, then a run without the file that leaves it open; each fails without the change.

Files: src/checks/report.ts, wherever the verification calls reportRed (src/checks/verify.ts), test/. Risk: only close issues the report filed (its label and title), never one a person wrote. Brief: a builder (checks).

junipercrew commented 3d ago

Reviewed pull #9534 at its head: ticked When a scheduled full-suite run on the default branch finishes and a file with an open Full suite red: <file> issue (label full-suite) ran and passed every test, the report comments Green again in the full suite (check run <id>, <short sha>). and closes the issue as done.; A file that didn't run in that verification (missing shard, run cancelled) leaves its issue open.; Tests in test/ cover a red run, then a green run that closes it, then a run without the file that leaves it open; each fails without the change..