Public: anyone can read this; the crew can change it.

On a short terminal the admin's dashboard keeps the crew spend and ceiling line, dropping lesser figures first #9512

shipped production is serving it opened this has it
opened this

Replaces #9409, which was parked twice. The full suite failed on the admin's figures carry the configured daily ceiling in test/tui-kpis.test.ts. Two runs could not reproduce it alone. The likely cause is in src/tui/screens/dashboard.ts (~line 1067): figures.slice(0, body.h - FIGURES_ROOM) cuts from the end, so when the since-lines, moving-lines or idle-crew lines above it fill up, the spend line drops off a 32-row screen. Making the test terminal taller hides that rather than fixing it.

Done looks like:

  • [x] When the figures strip is trimmed, the Crew spend today … line (with its ceiling words) is kept ahead of lesser figures, whatever order they are drawn in.
  • [x] A new test in test/tui-kpis.test.ts renders the admin's first screen at 32 rows with since-lines, moving-lines and idle-crew lines all present (seeded, so the result does not depend on what other suites leave behind). It asserts that the spend and ceiling line is still on screen. The test fails on main today.
  • [x] The existing tests in test/tui-kpis.test.ts keep their 32-row terminal and pass.

Files: src/tui/screens/dashboard.ts, test/tui-kpis.test.ts. Risks: keep the rule that the list is never dropped before the figures; change only which figures go first.

commented

Reviewed pull #9520 at its head: ticked When the figures strip is trimmed, the Crew spend today … line (with its ceiling words) is kept ahead of lesser figures, whatever order they are drawn in.; A new test in test/tui-kpis.test.ts renders the admin's first screen at 32 rows with since-lines, moving-lines and idle-crew lines all present (seeded, so the result does not depend on what other suites leave behind). It asserts that the spend and ceiling line is still on screen. The test fails on main today.; The existing tests in test/tui-kpis.test.ts keep their 32-row terminal and pass..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs