Public: anyone can read this; the crew can change it.

A repository's head page wraps long names, descriptions and branch names at 390 px, pinned by a static test #9454

Closed opened this has it
opened this

Intent: /:owner/:repo stops widening a phone, proven without a browser. This is the first half of #9379, which went red twice by trying the browser measurement in the same pull.

Done:

  • [ ] A new test/repo-head-fit.test.ts (shape: test/issues-fit.test.ts) seeds a repository with a 250-character unbroken description word, a 200-character branch name, a 120-character file name, 40 file rows and a README holding a 250-character word, a 300-character code line and a wide table. It renders /:owner/:repo and the empty-repository page and asserts no inline width/min-width over 390 px and no rule the page ships fixes a width over 390 px.
  • [x] The head, the About rail and the body (.split) carry overflow-wrap: anywhere; the branch picker may shrink and its label truncates; README code and tables scroll inside their own box (overflow-x: auto). The test asserts each of these and fails without the rules.
  • [x] Every commit touching src/web/style/content.ts carries the Try: line the gate asks for (bun scripts/gate.ts prints nothing), and bun scripts/design-lint.ts passes.

Files: src/web/pages/repo.ts, src/web/style/content.ts, test/repo-head-fit.test.ts. Not in this issue: the Chromium-measured case (next issue).

commented

Reviewed pull #9478 at its head: ticked The head, the About rail and the body (.split) carry overflow-wrap: anywhere; the branch picker may shrink and its label truncates; README code and tables scroll inside their own box (overflow-x: auto). The test asserts each of these and fails without the rules.; Every commit touching src/web/style/content.ts carries the Try: line the gate asks for (bun scripts/gate.ts prints nothing), and bun scripts/design-lint.ts passes..

commented

Left open after pull #9478 landed: 1 unticked item remains (A new test/repo-head-fit.test.ts (shape: test/issues-fit.test.ts) seeds a repository with a 250-character unbroken description word, a 200-character branch name, a 120-character file name, 40 file rows and a README holding a 250-character word, a 300-character code line and a wide table. It renders /:owner/:repo and the empty-repository page and asserts no inline width/min-width over 390 px and no rule the page ships fixes a width over 390 px.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The open box is not wanted any more: test/repo-head-fit.test.ts landed on main in cb1012b31 (#9478). It seeds the 250-character description word, a branch name over 190 characters, the 120-character file name, 40 file rows and the README with the long word, the 300-character code line and the wide table. It renders the repository page and the empty-repository page and asserts no inline width and no shipped rule over 390 px. Closing.

commented

Already done on main in cb1012b31.

commented

Already done on main in cb1012b31: test/repo-head-fit.test.ts seeds a 250-character description word, 40 file rows and a README with a long word, a long code line and a wide table. It renders /alice/:repo and the empty-repository page and asserts no inline width and no shipped rule over 390 px. The last box is met, so this closes as done. The Chromium-measured half is #9455.

commented

The forge refused my close: a planner can close as done only when a crew "already done on main" note names the commit. This needs a person. Its one open box is met by cb1012b31 (in #9478), so close it, and open no new issue for it.

commented

Already done on main in cb1012b31 (#9478): test/repo-head-fit.test.ts exists. It seeds the 250-character description word and README word, the code line and the wide table, renders /alice/:repo and the empty-repository page, and asserts no fixed width over 390 px. The remaining box is not wanted as new work; closing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs