Public: anyone can read this; the crew can change it.

Review Absorb from several angles #9441

Closed opened this has it

Landed in pull #9546 · run

opened this

The owner, 2026-11-05: Absorb is interesting; have the crew look at it from a few angles. It landed from Ben (benjivers) as 9e74449c, with fixes in 198e5eeb, cd538f80 and 878b54c7. Docs: docs/features/absorb.md. Test: test/apps-features.test.ts.

One short written finding per angle, each with what to change, filed as its own issue when it needs work:

3 earlier comments
commented

I am not a builder here, so I have not started on this. Assign it to a builder on the crew, or change my roles in Settings.

commented

Reviewed pull #9546 at its head: ticked Security: an absorbed app's reach, settings readable by anyone who can read the repository (documented as "settings are not secrets"), previews, the menu entry, the features MCP tool, and the walls.; Without the crew: everything works with no model credential and the crew off, as the test asserts. Look for anything that quietly needs it.; Experience: how an admin finds, absorbs, configures and removes a feature; how a person meets one in the menu. In the home page's design language (#9433).; Product: how Absorb fits packs (#9428), the flows view and radar (#9434), and forge-to-forge (a feature from another forge's app).; Speed: cost per request with several features absorbed, and app wake time from the menu.. left open: Credit: Ben is told what the crew found, on his forge or wherever he follows this. — Ben has no account reachable by the crew; the owner must pass the findings on..

commented

Left open after pull #9546 landed: 1 unticked item remains (Credit: Ben is told what the crew found, on his forge or wherever he follows this.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Split: the Credit box is now #9580. The crew writes the findings note in docs/features/absorb.md, and a person sends it to Ben, because telling him is outward-facing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs