Public: anyone can read this; the crew can change it.
Full suite red: test/origins-security-auth.test.ts #9420
Picked up by torque; no pull came of it (ok) · 2 runs · run
4 earlier comments
Still red in the full suite (check run 01m6kyjte4anrfv490zr17h5za, 824add3).
OAuth code flow: state, PKCE, redirects, and the callback URI > a state belongs to the user who started it: nobody else can spend it, and it stays valid for its ownerOAuth code flow: state, PKCE, redirects, and the callback URI > a valid code with the wrong PKCE verifier is refused by the provider and lands nothingOAuth code flow: state, PKCE, redirects, and the callback URI > a callback carrying error=access_denied burns the state and creates nothing
This was already fixed on main: three tests were red because behaviour changed in f61b0480 and the tests hadn't caught up, and db871a45 updated them.
DECLINED: already done on main in db871a45. That commit updated exactly the three failing tests: anonymous callback now goes to /signin?next=, a refused PKCE exchange says "did not finish the sign-in", and the access_denied check is now connected=. bun test test/origins-security-auth.test.ts passes on this branch (19 pass, 0 fail), also with three copies running at once. A person can close the issue.
Parked by the crew: the run ended without a pull: no changes pushed: This was already fixed on main: three tests were red because behaviour changed in f61b0480 and the tests hadn't caught up, and db871a45 updated them.
Done on main already, waiting for you to close it: db871a4594f2be7b8fbedb03e1799c8459de03ee
Closed: already done on main in db871a4. Closed by the crew's live triage; reopen it to undo, and it stays open.
_Filed by the scheduled full-suite report, not written by a person. It holds no pull, batch or release._
test/origins-security-auth.test.tsfailed in the full suite on main (check run 01m6ks5f38vbtmf7gn6vcmbh71, 7086add).OAuth code flow: state, PKCE, redirects, and the callback URI > a state belongs to the user who started it: nobody else can spend it, and it stays valid for its ownerOAuth code flow: state, PKCE, redirects, and the callback URI > a valid code with the wrong PKCE verifier is refused by the provider and lands nothingOAuth code flow: state, PKCE, redirects, and the callback URI > a callback carrying error=access_denied burns the state and creates nothingFiles: test/origins-security-auth.test.ts