Public: anyone can read this; the crew can change it.

A look keeps its page's size: scrollWidth, scrollHeight, innerWidth and innerHeight are stored on the look and read back #9385

Closed opened this
opened this

The capture already records size (src/looks/capture.ts, parseRecorded, on main in 84125d16c) and #9320 hands it to the check summary. This keeps it on the look itself so anything that reads looks later can answer "does this page scroll sideways" without a browser.

Done looks like:

  • [ ] The look table gains four nullable integer columns (a migration in the existing pattern of src/core/looks.ts); toLook returns them as size: { scrollWidth, scrollHeight, innerWidth, innerHeight } or leaves size absent when any is null.
  • [ ] src/looks/service.ts writes the recorded size when it saves a look; a look recorded without a size stores nulls, never a failure.
  • [ ] One new test file: a look saved with a size reads it back; one saved without reads no size; an existing row from before the migration reads no size. Each fails without the change. No browser starts in the test.

Files: src/core/looks.ts, src/looks/service.ts, one new test file. Risks: don't touch src/http/api.ts or what a reader may fetch; the pictures and their paths are unchanged.

commented

Replaced by #10202: not on main; re-planned as ready work under P7. #9386 now waits for #10202.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs