Public: anyone can read this; the crew can change it.

Settings › People fits a 390 px phone: no sideways scroll, long usernames and role controls wrap #9374

Closed opened this
opened this

Intent: /settings/people reads on a 390 px phone without sideways scroll, in the same way the issues, pulls, waves and milestones pages now do (see test/issues-fit.test.ts and test/milestones-fit.test.ts for the shape).

Done:

  • [ ] A new test/people-fit.test.ts seeds the page with long content: an unbroken 250-character word where the page shows a name or title, a long title, and many rows. It renders /settings/people and asserts no inline width/min-width over 390 px and no rule the page ships fixes a width over 390 px.
  • [ ] The containers holding long text carry overflow-wrap: anywhere (or break-word); the test asserts it. Wide content that must not wrap (code, a tree, a table) scrolls inside its own box (overflow-x: auto), never the page.
  • [ ] Like test/milestones-fit.test.ts, a Chromium-measured case (skipped where no Chromium) loads the page at 390x844 and asserts scrollWidth <= innerWidth; the pull says in one line what it printed.
  • [ ] The test fails without the fix, or, if the page already fits, it pins that and the pull says so.
  • [ ] bun test and bun scripts/design-lint.ts pass.

Files: test/people-fit.test.ts, src/web/pages/people.ts, src/web/style/ (only the rules the page needs).

This adds no preview look; the preview list of looks stays as it is.

Risks: a shared component rule changed for this page reaches other pages; prefer a rule scoped to this page's class, and run the other *-fit tests.

Fits: a builder's brief (scout or mason).

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #9380 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

Done on main already, waiting for you to close it: 932b4acb0f6973fa3a49ad2cc04c4fd2a761604f

commented

Closed: already done on main in 932b4ac. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs