Public: anyone can read this; the crew can change it.

A crew run's page fits a 390 px phone: its log lines and file paths wrap or scroll inside their box, never the page #9347

Closed opened this has it
opened this

The owner opens a crew run's page on a 390 px phone. The page must not scroll sideways, and no single row or card should be taller than the screen. Follow the pattern of test/bets-card-fit.test.ts (#9286), as #9323–#9328 do for their pages.

Done looks like:

  • [ ] A test renders a crew run's page with seeded long content: a 300-character unbroken word, a long title, many rows. It asserts that no inline width/min-width and no rule the page ships fixes a width over 390 px, and that the long-text containers carry overflow-wrap: anywhere (or break-word); code, logs and diffs may instead scroll inside their own box (overflow-x: auto on that box). It fails without the fix, or, if the page already fits, it pins that.
  • [x] Anything it finds is fixed in src/web/pages/runs.ts. Any new class is named in docs/design/areas/runs.md (create it if absent), not docs/DESIGN.md.
  • [x] The pull description links the preview's phone look of /preview-admin/sample/runs/<a seeded run id>, and says in one line whether it scrolls sideways.
  • [x] bun scripts/design-lint.ts passes. Run the new test file and the page's existing tests; the forge runs the rest.

Files: src/web/pages/runs.ts (runPage), docs/design/areas/runs.md, one new test file. Risks: change no route and no data read. Don't touch src/http/api.ts. One page per pull; do not widen it to sibling pages.

commented

Reviewed pull #9359 at its head: ticked Anything it finds is fixed in src/web/pages/runs.ts. Any new class is named in docs/design/areas/runs.md (create it if absent), not docs/DESIGN.md.; The pull description links the preview's phone look of /preview-admin/sample/runs/<a seeded run id>, and says in one line whether it scrolls sideways.; bun scripts/design-lint.ts passes. Run the new test file and the page's existing tests; the forge runs the rest..

commented

Left open after pull #9359 landed: 1 unticked item remains (A test renders a crew run's page with seeded long content: a 300-character unbroken word, a long title, many rows. It asserts that no inline width/min-width and no rule the page ships fixes a width over 390 px, and that the long-text containers carry overflow-wrap: anywhere (or break-word); code, logs and diffs may instead scroll inside their own box (overflow-x: auto on that box). It fails without the fix, or, if the page already fits, it pins that.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The open box is met on main: test/run-page-fit.test.ts (831ae6a14) seeds a 300-character word and asserts overflow-wrap on #run-head and #run-live. Nothing is left to build, so I'm closing it as dropped.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs