Public: anyone can read this; the crew can change it.

A pull's page fits a 390 px phone: its title, branch names and conversation wrap instead of scrolling sideways #9327

Closed opened this has it
opened this

The owner opens /preview-admin/sample/pulls/3 on a 390 px phone. The page must not scroll sideways, and no single row or card should be taller than the screen. Follow the pattern of test/bets-card-fit.test.ts (#9286).

Done looks like:

  • [x] A test renders a pull's page (conversation tab, with a 200-character branch name and a long unbroken word in a comment) with seeded long content: a 300-character unbroken word, a long title, many rows. It asserts that no inline width/min-width and no rule the page ships fixes a width over 390 px, and that the long-text containers carry overflow-wrap: anywhere (or break-word). It fails without the fix, or, if the page already fits, it pins that.
  • [x] Anything it finds is fixed in src/web/pages/pull.ts. Any new class is named in docs/design/areas/pull.md, not docs/DESIGN.md.
  • [ ] The pull description links the preview's phone look of /preview-admin/sample/pulls/3, and says in one line whether it scrolls sideways.
  • [x] bun scripts/design-lint.ts passes. Run the new test file and the page's existing tests; the forge runs the rest.

Files: src/web/pages/pull.ts, docs/design/areas/pull.md, one new test file. Risks: change no route and no data read. Don't touch src/http/api.ts.

The diff may scroll sideways inside its own box. The page itself may not.

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #9342 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Reviewed pull #9356 at its head: ticked A test renders a pull's page (conversation tab, with a 200-character branch name and a long unbroken word in a comment) with seeded long content: a 300-character unbroken word, a long title, many rows. It asserts that no inline width/min-width and no rule the page ships fixes a width over 390 px, and that the long-text containers carry overflow-wrap: anywhere (or break-word). It fails without the fix, or, if the page already fits, it pins that.; Anything it finds is fixed in src/web/pages/pull.ts. Any new class is named in docs/design/areas/pull.md, not docs/DESIGN.md.; bun scripts/design-lint.ts passes. Run the new test file and the page's existing tests; the forge runs the rest.. left open: The pull description links the preview's phone look of /preview-admin/sample/pulls/3, and says in one line whether it scrolls sideways. — It links the preview but does not state whether it scrolls sideways; it infers no scroll from a green check and quotes no measurement..

commented

Left open after pull #9356 landed: 1 unticked item remains (The pull description links the preview's phone look of /preview-admin/sample/pulls/3, and says in one line whether it scrolls sideways.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs