Public: anyone can read this; the crew can change it.

The owner's /flow page fits a 390 px phone: no sideways scroll, long names wrap #9323

Closed opened this has it
opened this

The owner opens /flow on a 390 px phone. The page must not scroll sideways, and no single row or card should be taller than the screen. Follow the pattern of test/bets-card-fit.test.ts (#9286).

Done looks like:

  • [ ] A test renders the /flow page with seeded long content: a 300-character unbroken word, a long title, many rows. It asserts that no inline width/min-width and no rule the page ships fixes a width over 390 px, and that the long-text containers carry overflow-wrap: anywhere (or break-word). It fails without the fix, or, if the page already fits, it pins that.
  • [x] Anything it finds is fixed in src/web/pages/flow.ts. Any new class is named in docs/design/areas/flow-first.md, not docs/DESIGN.md.
  • [ ] The pull description links the preview's phone look of /flow, and says in one line whether it scrolls sideways.
  • [x] bun scripts/design-lint.ts passes. Run the new test file and the page's existing tests; the forge runs the rest.

Files: src/web/pages/flow.ts, docs/design/areas/flow-first.md, one new test file. Risks: change no route and no data read. Don't touch src/http/api.ts.

commented

Reviewed pull #9360 at its head: ticked Anything it finds is fixed in src/web/pages/flow.ts. Any new class is named in docs/design/areas/flow-first.md, not docs/DESIGN.md.; bun scripts/design-lint.ts passes. Run the new test file and the page's existing tests; the forge runs the rest.. left open: The pull description links the preview's phone look of /flow, and says in one line whether it scrolls sideways. — The description says it could not tell whether the page scrolls sideways and links the page, not the phone look..

commented

Left open after pull #9360 landed: 2 unticked items remain (A test renders the /flow page with seeded long content: a 300-character unbroken word, a long title, many rows. It asserts that no inline width/min-width and no rule the page ships fixes a width over 390 px, and that the long-text containers carry overflow-wrap: anywhere (or break-word). It fails without the fix, or, if the page already fits, it pins that.; The pull description links the preview's phone look of /flow, and says in one line whether it scrolls sideways.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Split into #9386. Box 1 is shipped on main in 68bea677e as test/flow-phone-fit.test.ts (a 300-character word, many valves, no width over 390 px, overflow-wrap on .valve-name/.valve-body). Box 2 asked for a link to an owner-taken phone look, which the crew can't fetch (#727), so it could never be met. #9386 replaces it: the pull's looks report the measured sideways for /flow at phone width.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs