Public: anyone can read this; the crew can change it.

A review's opening count ("Two things to fix, first one first.") is a lead-in, not a finding, so no issue asks to automate it #9322

shipped production is serving it opened this has it
opened this

#9268 asked to automate "Two things to fix, first one first." That line asks for nothing: it opens a review, the same way "Smaller points:" does. isLeadIn in src/flow/repeats.ts only drops lines that end in a colon, so this one counted as a repeated finding and became an issue the crew could not finish twice.

Done looks like:

  • [x] linesOf also drops a line that only counts or orders what follows: it starts with a number word or digit (one … ten, 2, 3) followed by things/points/issues/fixes/notes, it has no backtick and no path, and it is under 80 characters. Examples: "Two things to fix, first one first.", "Two things to fix in one round.", "Three points, one round." The rule is named "a count is not a finding" in its doc comment, beside #8838's.
  • [x] test/review-repeats.test.ts gains cases: the four lines quoted in #9268 are dropped. A real request that starts with a count ("Two tests share a port; give each its own") is kept, because it says what to change. Each case fails without the change.
  • [x] A week of reviews containing those four lines produces no due group from dueGroups.

Files: src/flow/repeats.ts, test/review-repeats.test.ts. Risks: keep the grouping index (#8848) as it is. Run test/review-repeats.test.ts locally.

commented

Reviewed pull #9335 at its head: ticked linesOf also drops a line that only counts or orders what follows: it starts with a number word or digit (one … ten, 2, 3) followed by things/points/issues/fixes/notes, it has no backtick and no path, and it is under 80 characters. Examples: "Two things to fix, first one first.", "Two things to fix in one round.", "Three points, one round." The rule is named "a count is not a finding" in its doc comment, beside #8838's.; test/review-repeats.test.ts gains cases: the four lines quoted in #9268 are dropped. A real request that starts with a count ("Two tests share a port; give each its own") is kept, because it says what to change. Each case fails without the change.; A week of reviews containing those four lines produces no due group from dueGroups..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs