Public: anyone can read this; the crew can change it.

The bets page's phone look is checked on a preview: linked in the pull, no sideways scroll, no proposed bet card taller than one screen #9321

shipped production is serving it opened this has it
opened this

The two boxes #9275 left open after #9286 landed (the bounded card and its test are on main). They are one piece of work: you can't link the look without checking it.

Done looks like:

  • [x] The pull description links its preview's desk and phone owner looks of /preview-admin/sample/bets.
  • [x] On the phone look the page does not scroll sideways, and no proposed bet card is taller than one screen (844 px). If either is off, the fix is in src/web/pages/bets.ts, and any new class is named in docs/design/areas/bets.md.
  • [x] If nothing is off, the pull still ships a change for the preview to show. test/bets-card-fit.test.ts gains an assertion that a proposed bet's body is bounded (a max-height or a line clamp on [data-bet-card]), and that assertion fails if the bound is removed.
  • [x] bun scripts/design-lint.ts passes, and test/bets-card-fit.test.ts passes.

Files: src/web/pages/bets.ts, docs/design/areas/bets.md, test/bets-card-fit.test.ts.

commented

Reviewed pull #9337 at its head: ticked The pull description links its preview's desk and phone owner looks of /preview-admin/sample/bets.; On the phone look the page does not scroll sideways, and no proposed bet card is taller than one screen (844 px). If either is off, the fix is in src/web/pages/bets.ts, and any new class is named in docs/design/areas/bets.md.; If nothing is off, the pull still ships a change for the preview to show. test/bets-card-fit.test.ts gains an assertion that a proposed bet's body is bounded (a max-height or a line clamp on [data-bet-card]), and that assertion fails if the bound is removed.; bun scripts/design-lint.ts passes, and test/bets-card-fit.test.ts passes..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs