Public: anyone can read this; the crew can change it.

The check summary's vitals table names a phone look that scrolls sideways and how many screens tall each look is #9320

Closed opened this has it
opened this

Second part of #9249.

Done looks like:

  • [x] src/looks/service.ts passes the recorded size into each LookVitals entry, beside entries.
  • [ ] Where the check summary prints the vitals table (src/checks/looks.ts), each row shows screens = scrollHeight / innerHeight, rounded to one decimal. Below the table, one plain line names each phone look whose scrollWidth is greater than its innerWidth, for example "phone /preview-admin/sample/held scrolls sideways". There is no banner and no red, and a look without a size shows nothing.
  • [x] One test file covers the stored size, the screens figure, and the line being present for a sideways phone look and absent otherwise. Each fails without the change.
  • [ ] Comment on #9240 with the held and bets phone looks' screens from this pull's own check.

Files: src/looks/service.ts, src/checks/looks.ts, one new test file. Risks: don't touch src/http/api.ts. One picture at a time stays the rule.

commented

Reviewed pull #9389 at its head: ticked src/looks/service.ts passes the recorded size into each LookVitals entry, beside entries.; One test file covers the stored size, the screens figure, and the line being present for a sideways phone look and absent otherwise. Each fails without the change.. left open: Comment on #9240 with the held and bets phone looks' screens from this pull's own check. — The comment has not been posted; it needs a check run on this pull..

commented

Left open after pull #9389 landed: 2 unticked items remain (Where the check summary prints the vitals table (src/checks/looks.ts), each row shows screens = scrollHeight / innerHeight, rounded to one decimal. Below the table, one plain line names each phone look whose scrollWidth is greater than its innerWidth, for example "phone /preview-admin/sample/held scrolls sideways". There is no banner and no red, and a look without a size shows nothing.; Comment on #9240 with the held and bets phone looks' screens from this pull's own check.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The first box is met on main in 854bd48c0: src/checks/summary.ts carries screens per look and sidewaysLine. The second box, a one-off comment on #9240, is no longer wanted because every check summary now prints those screens. Closing it as dropped; #9385 no longer waits on it.

commented

Split instead. The first box is met on main (854bd48c0). The comment on #9240 is now #9458. #9385 needed only the first box, so it no longer waits.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs