Public: anyone can read this; the crew can change it.

A display.json is read into items and selections on main: Jay Moran's src/display model and arcade shelf compile and are tested #9279

Closed opened this
opened this

Replaces #9207, now that what it imports is its own issues (#9272, #9273).

Done looks like:

  • [ ] git checkout origin/incoming/jay-main -- src/display/config.ts src/display/items.ts src/display/known.ts src/display/selections.ts src/arcade/shelf.ts, adapting only imports to main.
  • [ ] Nothing imports src/display/launch.ts, src/arcade/host.ts or src/arcade/snapshot.ts yet.
  • [ ] test/display-model.test.ts reads a good display.json into items and selections, and refuses a malformed one with a named error.
  • [ ] bun x tsc --noEmit and bun test pass. Commits carry Co-authored-by: Jay Moran.

Files: the five above and the test. Risks: do not touch src/http/api.ts. If tsc names another missing import, add exactly that export from his branch and say so in the pull.

commented

replaced by #9329. This was parked only because #9273 closed as dropped, and #9273's four reads are on main at 5dc23ad25. #9329 is the same work, with nothing in front of it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs