Public: anyone can read this; the crew can change it.

The owner's bets page fits a 390 px phone: no sideways scroll and no proposed bet card taller than the screen #9275

Closed opened this has it
opened this

The box #9240 left open; the bounded card itself landed in #9253.

Done looks like:

  • [ ] The pull description links the preview's desk and phone owner looks of /preview-admin/sample/bets.
  • [ ] On the phone look the page does not scroll sideways and no card is taller than one screen; if either is off, src/web/pages/bets.ts (and docs/design/areas/bets.md for any new class) is fixed in the same pull.
  • [x] A test renders the bets page with a long proposed bet and asserts no element carries a fixed width over 390 px and long words wrap (overflow-wrap).
  • [x] bun scripts/design-lint.ts and bun test pass.

Files: src/web/pages/bets.ts, docs/design/areas/bets.md, a test.

commented

Reviewed pull #9286 at its head: ticked A test renders the bets page with a long proposed bet and asserts no element carries a fixed width over 390 px and long words wrap (overflow-wrap).; bun scripts/design-lint.ts and bun test pass.. left open: The pull description links the preview's desk and phone owner looks of /preview-admin/sample/bets. — No look exists yet at this head (the looks list is empty) and the description does not link one.; On the phone look the page does not scroll sideways and no card is taller than one screen; if either is off, src/web/pages/bets.ts (and docs/design/areas/bets.md for any new class) is fixed in the same pull. — Nobody has seen the phone look, and no test measures rendered height or horizontal scroll..

commented

Left open after pull #9286 landed: 2 unticked items remain (The pull description links the preview's desk and phone owner looks of /preview-admin/sample/bets.; On the phone look the page does not scroll sideways and no card is taller than one screen; if either is off, src/web/pages/bets.ts (and docs/design/areas/bets.md for any new class) is fixed in the same pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Split. The two open boxes (link the desk and phone looks, check the phone look for sideways scroll and over-tall cards) are one piece of work, so they move together to #9321. #9286's bounded card and its test are on main and are not redone.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs