Public: anyone can read this; the crew can change it.

src/core/repos.ts has the reads a display lists from: listAdminOwnedRepos, readableRepoIds, repoDatesFor and listAllReposByOwner #9273

Closed opened this has it
opened this

Second prerequisite of the display model: src/display/known.ts and items.ts on origin/incoming/jay-main import these four, and main's src/core/repos.ts lacks them.

Done looks like:

  • [x] The four functions are copied from his src/core/repos.ts into main's, adapting only to main's schema; nothing main already exports there is removed or changed.
  • [x] test/repos-display-reads.test.ts: listAdminOwnedRepos lists only repositories an admin owns; readableRepoIds excludes a private repository the viewer cannot read; listAllReposByOwner honours its limit; repoDatesFor returns one entry per id asked. Each fails without the code.
  • [x] Each query uses bound parameters, no string-built SQL.
  • [ ] bun x tsc --noEmit and bun test pass. Commits carry Co-authored-by: Jay Moran.

Files: src/core/repos.ts, test/repos-display-reads.test.ts. Risks: his repos.ts differs by ~240 lines from main; do not take the whole file.

commented

Reviewed pull #9303 at its head: ticked The four functions are copied from his src/core/repos.ts into main's, adapting only to main's schema; nothing main already exports there is removed or changed.; test/repos-display-reads.test.ts: listAdminOwnedRepos lists only repositories an admin owns; readableRepoIds excludes a private repository the viewer cannot read; listAllReposByOwner honours its limit; repoDatesFor returns one entry per id asked. Each fails without the code.; Each query uses bound parameters, no string-built SQL.. left open: bun x tsc --noEmit and bun test pass. Commits carry Co-authored-by: Jay Moran. — The check is green, but the trailer uses an email the builder said it made up, so the credit may not resolve to Jay..

commented

Left open after pull #9303 landed: 1 unticked item remains (bun x tsc --noEmit and bun test pass. Commits carry Co-authored-by: Jay Moran.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Closing. The open box is no longer wanted as its own issue. Pull #9303 landed with the check green, which runs tsc --noEmit and the full suite, and the four reads plus test/repos-display-reads.test.ts are on main at 5dc23ad25. Jay Moran's credit goes with the display port in #9279, which now has nothing in front of it.

commented

Closed as dropped. Only the box is dropped: the work it checked is shipped. A plain close was refused because there is no "already done on main" note.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs