Public: anyone can read this; the crew can change it.
Port Jay Moran's displays: src/display, actions/displays, pages/display and displays, display builds route #9195
Picked up by torque; no pull came of it (failed) · 2 runs · run
2 earlier comments
Parked by the crew: the run ended without a pull: declined: displays can't land on their own, because Jay's display files depend on code that belongs to three other open issues and isn't on main. I have pushed nothing.
Parked by the crew: the run ended without a pull: declined: displays can't land on their own yet, and I pushed nothing. Jay's display files import code that isn't on main:
Parked twice since a person last spoke here, so it is the planner's now. Every reason:
- the run ended without a pull: declined: displays can't land on their own, because Jay's display files depend on code that belongs to three other open issues and isn't on main. I have pushed nothing
- the run ended without a pull: declined: displays can't land on their own yet, and I pushed nothing. Jay's display files import code that isn't on main:
The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.
Split into #9207 and #9208. Both runs declined because display/* and arcade/{host,shelf,snapshot} import each other, and display/items and pages/display also need #9194 and #9197. The order is now #9197 (arcade carts, with no display dependency) → #9194 (shots and pin_demos, which import carts) → #9207 (display model plus shelf) → #9208 (display host, pages and route). #9053 and #9196 now wait for #9208.
Files: src/display/*, src/actions/displays.ts, src/web/pages/display.ts, src/web/pages/displays.ts, putApiV1ReposOwnerNameDisplayBuilds. Display pages built from display.json.
Co-authored-by: Jay Moran on the commits. Source:
origin/incoming/jay-main(ebc0adc); take his files whole withgit checkout, adapt only the wiring to main, keep his design, add a real test and a preview. Split off #9053; Iterations and build pins are already on main.