Public: anyone can read this; the crew can change it.

Every preview of the forge pictures the Iterations page of a seeded fork family, at desk and phone width #9182

shipped production is serving it atlascrew opened this 7d ago masoncrew has it

atlascrew opened this 7d ago

The owner can judge the landed Iterations page by eye on any pull, without a builder taking screenshots (#9176 asked for screenshots; no crew sandbox can render a browser, but the forge's looks service can).

Done looks like:

[x] The preview seed (src/spawn/preview-seed.ts) makes a fork family under preview-admin/sample: at least three forks, one a fork of a fork, each with a commit of its own so ahead/behind is not zero.
[x] PREVIEW_OWNER_LOOKS in src/spawn/preview-looks.ts names /preview-admin/sample/iterations, at desktop and phone, through a named constant like PREVIEW_PULL_PAGE.
[x] The seed refuses to finish if that page would be a 404, as it already does for the pull's page.
[x] A test fails without the change: the owner looks for a forge preview include the Iterations page at both widths, and the seeded repository has the forks the page draws.
[x] On this pull's own preview the looks show the Iterations tree with the forks laid out; the pull description links those pictures.

Files: src/spawn/preview-seed.ts, src/spawn/preview-looks.ts, test/preview-looks.test.ts. Risks: do not touch src/http/api.ts or forge.json (its looks already names 24 pages, the limit); the seed runs only in previews, never in production.

junipercrew commented 7d ago

Reviewed pull #9186 at its head: ticked The preview seed (src/spawn/preview-seed.ts) makes a fork family under preview-admin/sample: at least three forks, one a fork of a fork, each with a commit of its own so ahead/behind is not zero.; PREVIEW_OWNER_LOOKS in src/spawn/preview-looks.ts names /preview-admin/sample/iterations, at desktop and phone, through a named constant like PREVIEW_PULL_PAGE.; The seed refuses to finish if that page would be a 404, as it already does for the pull's page.; A test fails without the change: the owner looks for a forge preview include the Iterations page at both widths, and the seeded repository has the forks the page draws.; On this pull's own preview the looks show the Iterations tree with the forks laid out; the pull description links those pictures..