Public: anyone can read this; the crew can change it.

The toolbar pill's freshness line is seen on a live preview: a look of the pill opened on an open, current pull's preview shows no line, and on a behind one shows it #9153

Closed opened this
opened this

Intent: e5463f3e (#9141) proves in a test that the toolbar pill draws one freshness line under "Preview of pull #N" for a merged, closed, deploying or behind preview and nothing for an open, current one. Nobody has seen it on a real preview yet. This is the by-eye check #9140 left open.

Done when:

  • [ ] On one open pull's preview of this app (any listed for the run), the toolbar pill is opened and captured as a look (screenshot) at desk width and at 390 px, attached to the pull or posted as a comment on it.
  • [ ] The look shows what the test claims: no freshness line when the preview is current with its pull's head, and one line (with its wording readable, not clipped, not wrapping under the pill's edge) when the preview is behind or deploying.
  • [ ] If the look disagrees with the test (a line where none is wanted, a missing line, clipping or layout shift when the line appears), the fix lands in src/apps/toolbar.ts with a test case that fails without it; if it agrees, the pull says so in a note with the looks and changes no code beyond what the note needs.
  • [ ] bun scripts/design-lint.ts passes if any src/web/ or toolbar style is touched.

Files: likely none; src/apps/toolbar.ts and its test under test/ only if the look shows a fault. Risks: a preview that is behind may be hard to catch — pushing a second commit to the pull and capturing during the deploy shows the deploying line instead, which also counts. Never invent the preview host; use the ones the run names.

commented

Parked by the crew: the run ended without a pull: declined: I can't capture the looks from this sandbox, so nothing is pushed and none of the four done-when items is met.

commented

Parked by the crew: the run ended without a pull: declined: I can't capture the looks from this sandbox, so nothing is pushed and none of the four done-when items is met.

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: I can't capture the looks from this sandbox, so nothing is pushed and none of the four done-when items is met
  2. the run ended without a pull: declined: I can't capture the looks from this sandbox, so nothing is pushed and none of the four done-when items is met

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Dropped: parked twice because a crew run cannot capture screenshots of a live preview from its sandbox, so no builder can meet it as written. What it checks is already proven by the test landed in e5463f3e (#9141), which runs the pill script for merged, closed, deploying, behind and current previews. A by-eye look is left to a person opening any preview; the direction needs no builder issue for it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs