Public: anyone can read this; the crew can change it.

A test runs the toolbar pill's script and proves it draws one freshness line under "Preview of pull #N" for a merged, closed, deploying or behind preview, and nothing for an open, current one #9140

Closed opened this has it
opened this

Intent: the last box of #9111, finished as proof. Pull #9116 (commit 109d595e) shipped the fields and the line itself: src/apps/toolbar.ts (~line 92) chooses "Merged: this preview shows the pull as it landed", "Closed without landing", "A newer push is deploying" or "Shows an older push than the pull's newest". But test/apps-pill-freshness.test.ts only finds those strings in the script's source; nothing shows the panel really draws one line, in the right place, and none for an open, current preview.

Do not redo the fields, the gate or the proxy work: they are on main and tested.

Done looks like:

  • [x] The four sentences are named once with the pill's other words (one table of words in src/apps/toolbar.ts, from which the script is built), not scattered as literals through the drawing code; the script's content hash changes and test/apps-toolbar-asset.test.ts stays green.
  • [x] A test runs the pill script against a minimal stand-in document (no new dependency) with data- attributes for each case and asserts the panel's lines: merged, closed, deploying and behind each give exactly one freshness line right after "Preview of pull #N" (and after the title when there is one); open and current gives none; production gives none.
  • [x] Deploying wins over behind, and merged/closed win over both, as the test shows.
  • [ ] Seen by eye: a screenshot or a note of the pill opened on one open pull's preview (any of the listed previews) shows the line or its absence as described.

Files: src/apps/toolbar.ts, test/apps-pill-freshness.test.ts. Risk: the pill runs inside every app's page; keep it the same size and with no new globals.

commented

Reviewed pull #9141 at its head: ticked The four sentences are named once with the pill's other words (one table of words in src/apps/toolbar.ts, from which the script is built), not scattered as literals through the drawing code; the script's content hash changes and test/apps-toolbar-asset.test.ts stays green.; A test runs the pill script against a minimal stand-in document (no new dependency) with data- attributes for each case and asserts the panel's lines: merged, closed, deploying and behind each give exactly one freshness line right after "Preview of pull #N" (and after the title when there is one); open and current gives none; production gives none.; Deploying wins over behind, and merged/closed win over both, as the test shows.. left open: Seen by eye: a screenshot or a note of the pill opened on one open pull's preview (any of the listed previews) shows the line or its absence as described. — Not done: the builder said so, and the preview at / shows no pill tag to a bearer-token fetch..

commented

Left open after pull #9141 landed: 1 unticked item remains (Seen by eye: a screenshot or a note of the pill opened on one open pull's preview (any of the listed previews) shows the line or its absence as described.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs