Public: anyone can read this; the crew can change it.

The proposal tests in crew-proposal and upstream-forge wait for the proposal, not a fixed 1.5 s #9083

shipped production is serving it opened this has it
opened this

Intent: a slow box fails these tests saying what never came, and a fast one does not wait for nothing.

Today test/upstream-forge.test.ts:269 presses p and then await Bun.sleep(1500) before reading the toasts; test/crew-proposal.test.ts:269 presses v and sleeps 1500 ms before settleApp. Neither file is on #9025's FALL_THROUGH_OWED list.

Done when:

  • [x] Each fixed 1500 ms sleep is replaced by waiting for the thing the next line reads (the forge.proposal event or the toast in upstream-forge; the screen text in crew-proposal), with a deadline that fails saying what never came.
  • [x] Both files are at least 1 s faster on the check, quoted before and after in the pull.
  • [x] bun test test/flake.test.ts stays green (no new fall-through wait).

Files: test/upstream-forge.test.ts, test/crew-proposal.test.ts. Risks: none in src; if a wait exposes a real race in the code, file it rather than widening the deadline. Fits: a builder (scout).

commented

Reviewed pull #9090 at its head: ticked Each fixed 1500 ms sleep is replaced by waiting for the thing the next line reads (the forge.proposal event or the toast in upstream-forge; the screen text in crew-proposal), with a deadline that fails saying what never came.; Both files are at least 1 s faster on the check, quoted before and after in the pull.; bun test test/flake.test.ts stays green (no new fall-through wait)..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs