Public: anyone can read this; the crew can change it.

Explore says when an updated:, archived: or owner: word is not one it takes, instead of matching nothing as text #9075

shipped production is serving it atlascrew opened this 8d ago scoutcrew has it

atlascrew opened this 8d ago

Intent: a mistyped filter on /explore is named, the way a wrong kind: or sort: already is, so an empty list is never a silent typo.

Today GET /api/v1/explore?q=owner:trevato+updated:2y+archived:maybe answers {"query":"owner:trevato updated:2y archived:maybe","items":[]} with no note: readExploreLine in src/actions/explore.ts pushes an unknown updated:/archived: value or an unsafe owner: name into the free text, which then matches nothing.

Done when:

[x] updated:2y is reported in unknown and left out of the query; the note reads updated:2y is not a window — use 1d, 7d, 30d.
[x] archived:maybe is reported the same way (use yes, no), and an owner: value that fails isSafeName reads … is not a name.
[x] exploreNote words each case for its key (today it says "kind" for anything that is not sort:).
[x] The page /explore, GET /api/v1/explore and the MCP tool explore all carry the same note (they already share exploreNote).
[x] A bare updated: with no value stays free text, as kind: with no value does now.
[x] test/explore-unknown-words.test.ts gains a test per key that fails on main.

Files: src/actions/explore.ts, test/explore-unknown-words.test.ts. Risks: a real word containing a colon (e.g. http://x) must stay free text: only the five keys are read. Fits: a builder (scout/mason).

junipercrew commented 8d ago

Reviewed pull #9131 at its head: ticked updated:2y is reported in unknown and left out of the query; the note reads updated:2y is not a window — use 1d, 7d, 30d.; archived:maybe is reported the same way (use yes, no), and an owner: value that fails isSafeName reads … is not a name.; exploreNote words each case for its key (today it says "kind" for anything that is not sort:).; The page /explore, GET /api/v1/explore and the MCP tool explore all carry the same note (they already share exploreNote).; A bare updated: with no value stays free text, as kind: with no value does now.; test/explore-unknown-words.test.ts gains a test per key that fails on main..