Public: anyone can read this; the crew can change it.

Bring in Jay Moran's build pins and Iterations, ported onto main with his name on them #9041

Closed opened this has it

Landed in pull #9050

opened this

The owner: Jay has very good design sense; "bring in his ideas and do a clean merge". His fork: incoming/jay-main on this repository (ebc0adc). The feature table is on #9030, which is closed because its branch held an empty merge. Start a fresh branch off main and never merge his head; that comes last, after every feature is in, and isn't this issue.

This issue: the core additions pins need, as you listed: buildEnv and the build environment name, AppsRuntime.previewBuild, exactRefOid, moveRefLeased, notesIntent, PageOptions.frameSrc (loosens CSP, so scope it to the page that asks and call it out for the reviewer), then build pins, then the Iterations page on top. Two or three pulls off main, each landing alone. Take his files whole with git checkout incoming/jay-main -- <files>, adapt only the wiring to main, keep his page design, and bring only what Iterations needs from arcade and displays, or leave those parts quietly absent.

Also his small fix in src/actions/tell.ts, which you already worked out.

Done when:

2 earlier comments
commented

Reviewed pull #9050 at its head: ticked His flow-only, budget-retry, merge-proof files and the dev-UI wording rewrite stay out.; Next pieces (screenshots, displays, demo, arcade) are filed as follow-ups.. left open: /:owner/:name/iterations works on main with pins, tree layout, zoom and folds, and looks like his. — The Iterations page is not in this pull; it is follow-up #9052.; Every pull has Co-authored-by: Jay Moran, a preview and a real test. — This pull meets it, but the series of pulls is not finished, so the box stays open..

commented

Left open after pull #9050 landed: 2 unticked items remain (/:owner/:name/iterations works on main with pins, tree layout, zoom and folds, and looks like his.; Every pull has Co-authored-by: Jay Moran, a preview and a real test.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Atlas: #9050 landed the core (buildEnv, previewBuild, the build-preview action and tests). The open box, Iterations with pins, tree layout, zoom and folds, is carried by #9051 (build pins) and then #9052 (Iterations page). Each of those requires Co-authored-by: Jay Moran, a preview and a real test, so the second box goes with them. Closed as split into #9051 and #9052.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs