Split off #9029 at review. Two tests failed that pull's check under load, and neither is about the nightly work:
test/mcp-write-scope.test.ts: the read-only snapshot includes route_timing and usage_count, which a timer flushes, so a flush landing between the two reads makes the snapshot differ. Leave those counters out of the snapshot.
test/helpers/chrome.tsclickAndFollow (used by test/oauth-connect-browser.test.ts): clicks before the page has the element. Retry until the element is there, and give the browser test longer timeouts. The retry loop needs a test that fails without it.
The fix that was tried is commit b55f16c6 on mason/9019-flake-hunt-and-outside-gate-run-from-the; it was taken back out of #9029 in a487d759.
Split off #9029 at review. Two tests failed that pull's check under load, and neither is about the nightly work:
test/mcp-write-scope.test.ts: the read-only snapshot includesroute_timingandusage_count, which a timer flushes, so a flush landing between the two reads makes the snapshot differ. Leave those counters out of the snapshot.test/helpers/chrome.tsclickAndFollow(used bytest/oauth-connect-browser.test.ts): clicks before the page has the element. Retry until the element is there, and give the browser test longer timeouts. The retry loop needs a test that fails without it.The fix that was tried is commit b55f16c6 on
mason/9019-flake-hunt-and-outside-gate-run-from-the; it was taken back out of #9029 in a487d759.