Public: anyone can read this; the crew can change it.
Polls that run out of time and carry on in 47 test files: make each fail saying what never came #9025
Landed in pull #9073 · 2 runs · run
1 earlier comment · 1 event
the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented
Reviewed pull #9073 at its head: left open: FALL_THROUGH_OWED is empty, and each fixed file passed bun scripts/flake-hunt.ts admit (record in its pull). — FALL_THROUGH_OWED is empty, but the pull says admit was not run on any fixed file, so there is no record..
commented
Left open after pull #9073 landed: 1 unticked item remains (FALL_THROUGH_OWED is empty, and each fixed file passed bun scripts/flake-hunt.ts admit (record in its pull).). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.
Sign in to join this conversation.
new above
offline
From #9017.
fallThroughWaitsinscripts/flake.tsnames a poll that runs out of time and carries on: a loop that waits while a condition is false, at most N times or until a deadline, whose next statement neither checks nor returns the outcome. On a slow box it runs out silently and the test acts on a state that never came; that is howtest/conversation-queue.test.tspassed its own green check and then failed 3 in 6 on main (#8993).The gate now refuses a new one (
test/flake.test.ts), but these 47 files carry one today, listed inFALL_THROUGH_OWEDinscripts/flake.tsunder this issue. Each leaves the list in the pull that makes its wait fail saying what never came (or checks it on the next line); the rule goes red on a listed file that no longer breaches, so the list only shrinks.test/explore-rank.test.ts:45: for (let i = 0; i < 500 && !stopped; i++) {test/cell-relays-reaped.test.ts:90: while (Date.now() < deadline && seen === 0) {test/tui-grants.test.ts:63: for (let i = 0; i < 100 && !h.text().includes("which subscriptions each"); i++)test/forges-side-by-side.test.ts:36: while (!cellCounters().some((c) => c.label === "forge:fun") && Date.now() < wait) await Bun.sleep(50);test/tui-delete-repo.test.ts:71: for (let i = 0; i < 100 && !h.text().includes("cannot be undone"); i++)test/tui-forks-take.test.ts:117: for (let i = 0; i < 100 && (await behind("bob")) !== 0; i++) await Bun.sleep(50);test/act-now.test.ts:239: while (!text.includes(id: ${ids[2]}) && Date.now() < deadline) {test/system-stream.test.ts:78: while (!text.includes("98765") && Date.now() < deadline) {test/roll-write-pause.test.ts:96: for (let i = 0; i < 300 && !out.includes("the other forge let go of this database"); i++) await Bun.sleep(100);test/tui-newapp.test.ts:67: while (!done() && Date.now() < deadline) await Bun.sleep(20);test/check-pull-flake.test.ts:85: while (Date.now() < deadline && finished() === undefined) await Bun.sleep(100);test/client-abort.test.ts:76: for (let i = 0; i < 100 && servers.inFlight > 0; i++) await Bun.sleep(10);test/conversation-talk.test.ts:491: for (let i = 0; i < 80 && readFileSync(join(dir, "first.json"), "utf8") === seen; i++) await Bun.sleep(25);test/check-flake.test.ts:140: while (Date.now() < deadline && finished() === undefined) await Bun.sleep(100);test/event-order.test.ts:104: while (!text.includes(id: ${second}) && Date.now() < deadline) {test/conversation-queue-api.test.ts:40: for (let i = 0; i < 100 && !ok(); i++) await Bun.sleep(10);test/spawn-cell-socket.test.ts:71: for (let i = 0; i < 100 && !ok(); i++) await Bun.sleep(20);test/tui-origins-guard.test.ts:76: for (let i = 0; i < 40 && getOriginFor(forge.db, userId, originId) !== undefined && lastGuardTry(forge, originId) === undefined; i++)test/tui-origins-forge.test.ts:86: for (let i = 0; i < 50 && listOrigins(mine.db, getUserByName(mine.db, "alice")!.id).length === 0; i++) await Bun.sleep(100);test/tui-working-yours.test.ts:57: while (Date.now() < deadline && (text.includes("searching…") || (shows !== undefined && !text.includes(shows)))) {test/crew-merge-conflict.test.ts:91: while (!done() && Date.now() < end) await new Promise((r) => setTimeout(r, 10));test/crew-early.test.ts:75: while (mine().length === 0 && Date.now() < deadline) await Bun.sleep(100);test/crew-early.test.ts:132: while (mine().length === 0 && Date.now() < deadline) await Bun.sleep(100);test/crew-early.test.ts:213: while (mine().length === 0 && Date.now() < deadline) await Bun.sleep(100);test/merge-queue-parallel.test.ts:294: for (let i = 0; i < 2000 && open < 1; i++) await Bun.sleep(5);test/migrate-token-reach.test.ts:315: while (!tui.screen.toText().includes("carol-gh/closed") && Date.now() < end) {test/snapshot-restore-streamed.test.ts:80: for (let i = 0; i < 100 && diskBytes(dataDir) === 0; i++) await Bun.sleep(20);test/checks.test.ts:870: while (!done() && Date.now() < deadline) await Bun.sleep(25);test/tui-onyou.test.ts:225: for (let i = 0; i < 8 && !/> .Bob's chore|▸.Bob's chore/.test(h.text()); i++) await h.press("j");test/pull-red-alone-path.test.ts:126: while (!tui.screen.toText().includes(pull.title) && Date.now() < end) {test/looks-owner.test.ts:438: while (light().length < 6 && Date.now() < deadline) await Bun.sleep(100);test/looks-owner.test.ts:490: while (light().length < pages.length * 3 && Date.now() < deadline) await Bun.sleep(100);test/quotas-storage.test.ts:121: for (let i = 0; i < 100 && (await accountBytes(app, bobId)) < 1_500_000; i++)test/quotas-storage.test.ts:333: for (let i = 0; i < 100 && (await accountBytes(app, made.value.id)) < 1_500_000; i++)test/quotas-storage.test.ts:381: for (let i = 0; i < 100 && (await accountBytes(app, org.value.id)) < 1_500_000; i++)test/tui-hooks.test.ts:37: for (let i = 0; i < 100 && !h.text().includes("list, add and remove webhooks"); i++)test/backups-live.test.ts:175: while (Date.now() < until && !got.includes("backup.")) {test/following-card.test.ts:95: for (let i = 0; i < 125 && !page.includes('value="take"'); i++) {test/tui-resilience-now.test.ts:95: for (let i = 0; i < 100 && !h.text().includes(" taken: "); i++) {test/tui-resilience-now.test.ts:151: for (let i = 0; i < 100 && !h.text().includes(" taken: "); i++) {test/drill-board-line.test.ts:153: for (let i = 0; i < 100 && sent.length === 0; i++) await Bun.sleep(10);test/tui-teams.test.ts:139: while (!text.includes("7%") && Date.now() < deadline) {test/studio-door.test.ts:1369: while (!event && Date.now() < deadline) {test/check-memory-warning.test.ts:66: while (Date.now() < deadline && mine() === undefined) await Bun.sleep(100);test/spawn-child-runs-apps.test.ts:55: while (child.startingCount() > 0 && Date.now() < until) await Bun.sleep(100);test/crew-parks-planner.test.ts:75: while (e.fresh().directionIssueId == null && Date.now() < deadline) await Bun.sleep(50);test/crew-parks-planner.test.ts:175: while (e.fresh().directionIssueId == null && Date.now() < deadline) await Bun.sleep(50);test/crew-parks-planner.test.ts:181: while (settled() === undefined && Date.now() < deadline) await Bun.sleep(100);test/web-apps.test.ts:980: for (let i = 0; i < 200 && open() !== null; i++) await Bun.sleep(25);test/merge-queue-clash.test.ts:130: for (let i = 0; i < 2000 && open < 1; i++) await Bun.sleep(5);test/conflicts-tui.test.ts:152: for (let i = 0; i < 100 && (await tip("refs/heads/loud")) === was; i++) await Bun.sleep(50);test/tui-resilience-drill.test.ts:66: for (let i = 0; i < 100 && !app.screen.toText().includes(text); i++) {test/tui-origins.test.ts:123: for (let i = 0; i < 40 && listOrigins(forge.db, made.value.id)[0]!.lastSyncAt === null; i++) await Bun.sleep(100);test/apps-ssh.test.ts:240: while (!terminal.output().includes("j/k move") && Date.now() < deadline)test/live.test.ts:29: while (out.length < count && Date.now() < deadline) {Done when: