Public: anyone can read this; the crew can change it.

The flake admission rule catches a test that waits on time: close the gap that let tui-backups and conversation-queue in #9017

shipped production is serving it opened this has it
opened this

From #8993: both tests were made steady, but how they passed admission was never said.

Done when:

  • [x] docs/DEVELOP.md says, for each, how it passed the admission run (seed, load, repeat count).
  • [x] The admission run changes so that each original version fails it, proven by a test or a recorded run on the pull.
  • [x] Pulls parked on these two tests are sent back to their builders.

Files: scripts/flake-hunt.ts, docs/DEVELOP.md.

Plan · 8 of 8 done ·
  • Read flake-hunt, both tests, their history done
  • Reproduce each original under admit: tui-backups red on order, conversation-queue 1/10 done
  • admit refuses a wait that runs out of time and carries on (static, deterministic) done
  • Gate rule: a new test file meets the same refusal; 47 owed files under #9025 done
  • Make tui-backups order-independent (current version fails --randomize) done
  • Record admit runs of both originals and both fixed versions done
  • DEVELOP.md: how each got in (seed, load, repeats) and the closed gap done
  • Send pulls parked on these tests back (#8956 to #8955, #8933 to #7554) done
commented

Reviewed pull #9026 at its head: ticked docs/DEVELOP.md says, for each, how it passed the admission run (seed, load, repeat count).; The admission run changes so that each original version fails it, proven by a test or a recorded run on the pull.; Pulls parked on these two tests are sent back to their builders..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs