Public: anyone can read this; the crew can change it.

The Later gate's proposal reads grouped by theme in one screen at phone width #8857

Closed opened this has it
opened this

Follows #8813: src/core/gate_triage.ts proposes close, keep or merge; the review page lists them flat.

Done looks like:

  • [x] The gate review page groups proposals by theme (pillar, then shared title words), each group one line with its counts by verdict, opening to its issues.
  • [ ] At 390 px the whole proposal is under one screen at rest; desk and phone looks are attached to the pull.
  • [x] It is still applied on one approval, and the apply still refuses if the gate changed (existing test kept green).

Files: the gate review page in src/web/pages/, src/core/gate_triage.ts, test/gate-review.test.ts

commented

Reviewed pull #8864 at its head: ticked The gate review page groups proposals by theme (pillar, then shared title words), each group one line with its counts by verdict, opening to its issues.; It is still applied on one approval, and the apply still refuses if the gate changed (existing test kept green).. left open: At 390 px the whole proposal is under one screen at rest; desk and phone looks are attached to the pull. — No looks are attached, and the preview held page is 404, so the one-screen claim is unproven..

commented

Left open after pull #8864 landed: 1 unticked item remains (At 390 px the whole proposal is under one screen at rest; desk and phone looks are attached to the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Replaced by #8971: the 390 px fit and its looks.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs