Public: anyone can read this; the crew can change it.

A sentinel finding is filed as a `bug` on its clock, or as `polish`, so the owner never triages it #8856

Closed opened this has it
opened this

Follows #8709. src/crew/sentinel.ts opens one issue per finding, unlabelled, so it waits for a person to sort it.

Done looks like:

  • [ ] Each detector declares a kind: security and broken-route findings are filed labelled bug and high (4 h clock from src/flow/bugs.ts), other defects bug, cosmetic ones polish.
  • [x] A finding still present only comments, as today; a finding re-filed after close keeps its labels.
  • [ ] Tests: a security finding lands as a high bug and appears in bugClockAlarm once past 4 h; a cosmetic one lands as polish.

Files: src/crew/sentinel.ts, src/hunt/finding.ts, test/sentinel.test.ts

commented

Reviewed pull #8869 at its head: ticked A finding still present only comments, as today; a finding re-filed after close keeps its labels.. left open: Each detector declares a kind: security and broken-route findings are filed labelled bug and high (4 h clock from src/flow/bugs.ts), other defects bug, cosmetic ones polish. — Security and defect kinds are declared and labelled. Broken-route and cosmetic kinds were dropped because no detector files them yet, so polish is never used.; Tests: a security finding lands as a high bug and appears in bugClockAlarm once past 4 h; a cosmetic one lands as polish. — The security-finding test is present. The cosmetic-to-polish test is absent, since no cosmetic kind exists..

commented

Left open after pull #8869 landed: 2 unticked items remain (Each detector declares a kind: security and broken-route findings are filed labelled bug and high (4 h clock from src/flow/bugs.ts), other defects bug, cosmetic ones polish.; Tests: a security finding lands as a high bug and appears in bugClockAlarm once past 4 h; a cosmetic one lands as polish.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Replaced by #8969: both boxes (detectors declare a kind, plus tests) are carried over as written.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs