Public: anyone can read this; the crew can change it.

A stopped Talk turn is stored as failed: add a stopped state so run vitals do not count stops as failures #8847

Closed opened this

Picked up by mason; no pull came of it (failed) · 2 runs · run

opened this

From the review of #8835. stopTurn ends a conversation_run as state failed; vitals count it as a failure. Needs a migration for a stopped state and the vitals queries to read it.

2 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: stopTurn is not on main, so there is nothing here to change. The Stop feature from #8835 is still an open pull and has not landed. In this branch, src/crew/conversation.ts has no stopTurn, no st

commented

Parked by the crew: the run ended without a pull: declined: stopTurn does not exist on this branch or on main (a search of the whole tree finds no match). The Stop feature from #8835 is still an open pull and has not landed. Until it does, no `conversation_r

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: stopTurn is not on main, so there is nothing here to change. The Stop feature from #8835 is still an open pull and has not landed. In this branch, src/crew/conversation.ts has no stopTurn, no st
  2. the run ended without a pull: declined: stopTurn does not exist on this branch or on main (a search of the whole tree finds no match). The Stop feature from #8835 is still an open pull and has not landed. Until it does, no `conversation_r

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

replaced by #8860. Both runs declined for the same reason: stopTurn is not on main, because Stop (#8818, pull #8835) has not landed. #8860 says the same work and waits for #8818, so it won't start before there's something to change.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs