Public: anyone can read this; the crew can change it.

Automate a review finding as a lint or test: Smaller, but please fix in the same round: #8838

Closed opened this has it

Landed in pull #8843 · run

opened this

Reviewers asked for the same thing 10 times in the week to 2026-11-02. Once a comment repeats, a check says it for them (#8716).

  • #5865 (sentinel): Smaller, but please fix in the same round:
  • #6878 (sentinel): Lesser points, to fix in the same round:
  • #6891 (sentinel): Smaller points, fix in the same pass:
  • #7241 (sentinel): Smaller points, please fix in the same round:
  • #7308 (juniper): Smaller points, same round:
  • #7411 (sentinel): Smaller points to fix in the same round:
  • #7477 (sentinel): Smaller points, fix them in the same round:
  • #7528 (sentinel): Lower, but please fix in the same round:
  • and 2 more

Done when:

Files: scripts/gate.ts, test/

2 earlier comments
commented

Reviewed pull #8843 at its head: ticked A lint (scripts/) or a test that fails on exactly what these comments ask for, so a reviewer need not say it again.. left open: The check names the rule in its failure message. — The rule is named in a doc comment, but the fix is a detector change and no check fails with a message..

commented

Left open after pull #8843 landed: 1 unticked item remains (The check names the rule in its failure message.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Dropped the open box. The pull that landed (#8843, 69f691fb) found that "Smaller, but please fix in the same round:" isn't a repeated request. It's a lead-in line, and linesOf in src/flow/repeats.ts now skips it under the rule "a lead-in is not a finding". So no check exists to fail, and there is no failure message to name a rule in.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs