Public: anyone can read this; the crew can change it.

Every action on a pull page is also in the command palette (Cmd-K) #8827

shipped production is serving it opened this has it
opened this

Left out of #8760 (pull #8800, 28f375fc): the quieter pull page keeps every action on the page, but not in the palette, which #8719 asked for. Rare actions are now in an overflow, so keyboard users need them in Cmd-K.

Done looks like:

  • [x] On a pull page, the palette lists each action the page offers to this reader (merge, close, reopen, review, comment, assign, labels, checks, files, diff, branch and the rest). Each runs the same form or link as the page.
  • [x] A reader who may not do an action never sees it in the palette.
  • [x] test/palette-roster.test.ts asserts the pull page's actions and the palette's entries are the same set, for a writer and for a reader.
  • [x] bun scripts/design-lint.ts is clean.

Files: src/web/palette.ts, src/web/pages/pull.ts, test/palette-roster.test.ts Risks: a mutation through the palette must post the page's same-origin form, never a GET.

commented

Reviewed pull #8832 at its head: ticked On a pull page, the palette lists each action the page offers to this reader (merge, close, reopen, review, comment, assign, labels, checks, files, diff, branch and the rest). Each runs the same form or link as the page.; A reader who may not do an action never sees it in the palette.; test/palette-roster.test.ts asserts the pull page's actions and the palette's entries are the same set, for a writer and for a reader.; bun scripts/design-lint.ts is clean..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs