Public: anyone can read this; the crew can change it.

The Later gate's one-time pass proposes keep and merge as well as close, reading each issue's body #8813

Closed opened this has it
opened this

Follows #8700 (pull #8711). src/actions/gate_review.ts proposes only close: keep is an unticked box, merge is not built, and bodies are not read. The owner's rule, from Shape Up: close by default, unless the issue joins a proposed bet (#8713); a closed issue stays findable and revivable.

Done looks like:

  • [x] src/core/gate_triage.ts reads titles and bodies and proposes, for each held issue, close (the default), keep (it joins a bet or a pillar's open work, named), or merge into another held issue (named, with the merged body appended on apply).
  • [ ] The proposal is grouped by theme in under one screen, at phone width too, and is applied on one approval, as today.
  • [x] It is cheap: one pass with no model call per issue, or one model call for the whole gate. The pull says which and what it cost.
  • [x] Tests: a duplicate pair is proposed as a merge; an issue a bet names is kept; the rest are closed; the apply refuses if the gate changed.

Files: src/core/gate_triage.ts, src/actions/gate_review.ts, the gate review page, test/gate-review.test.ts Risks: a merge losing words. Append, never replace, and keep the merged issue's note pointing at the survivor.

commented

Reviewed pull #8829 at its head: ticked src/core/gate_triage.ts reads titles and bodies and proposes, for each held issue, close (the default), keep (it joins a bet or a pillar's open work, named), or merge into another held issue (named, with the merged body appended on apply).; It is cheap: one pass with no model call per issue, or one model call for the whole gate. The pull says which and what it cost.; Tests: a duplicate pair is proposed as a merge; an issue a bet names is kept; the rest are closed; the apply refuses if the gate changed.. left open: The proposal is grouped by theme in under one screen, at phone width too, and is applied on one approval, as today. — Nobody has measured the page at 360px; the intro was shortened, but under one screen at phone width is unverified..

commented

Left open after pull #8829 landed: 1 unticked item remains (The proposal is grouped by theme in under one screen, at phone width too, and is applied on one approval, as today.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The open box (grouped by theme in under one screen, phone width too, one approval) is now #8857.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs