Public: anyone can read this; the crew can change it.

The pull page shows less at rest, and every action it had stays one step away #8773

Closed opened this has it
opened this

Follows #8719. Pull #8722 (7802eb22) redid the issue list. This issue does the pull page the same way.

Done looks like:

  • [x] The pull page follows the rules in #8719's body (chrome recedes, whitespace before borders, 4–5 properties a row, status as a glyph with its word on hover, one primary action in a fixed place, rare actions in an overflow and the palette, hierarchy by size and weight, a few colour tokens), tuned hard toward Linear's calm as the owner asked, in our own identity.
  • [x] A test lists every action the page offered before (merge, close, review, comment, checks, files, diff, branch, assign, labels and the rest found on main) and finds each still reachable, and each in the command palette (Cmd-K). Model it on test/issues-quiet.test.ts.
  • [x] The page's HTML is smaller. The byte counts before and after are on the pull, and its byte budget is tightened in a test (#8016).
  • [ ] Desk and phone screenshots, before and after, are attached to the pull as looks. docs/design/areas/pull.md says in one line what the page is for, so a cold reader gets it in 10 seconds.
  • [x] bun scripts/design-lint.ts is clean.

Files: src/web/pages/pull.ts, src/web/studio/change.ts, src/web/studio/words.ts, docs/design/areas/pull.md, test/pull-quiet.test.ts (new) Risks: an action dropped by accident. The listing test is the guard, so write it first against main.

commented

Reviewed pull #8803 at its head: ticked The pull page follows the rules in #8719's body (chrome recedes, whitespace before borders, 4–5 properties a row, status as a glyph with its word on hover, one primary action in a fixed place, rare actions in an overflow and the palette, hierarchy by size and weight, a few colour tokens), tuned hard toward Linear's calm as the owner asked, in our own identity.; A test lists every action the page offered before (merge, close, review, comment, checks, files, diff, branch, assign, labels and the rest found on main) and finds each still reachable, and each in the command palette (Cmd-K). Model it on test/issues-quiet.test.ts.; The page's HTML is smaller. The byte counts before and after are on the pull, and its byte budget is tightened in a test (#8016).; bun scripts/design-lint.ts is clean.. left open: Desk and phone screenshots, before and after, are attached to the pull as looks. docs/design/areas/pull.md says in one line what the page is for, so a cold reader gets it in 10 seconds. — No screenshots are attached; the sandbox cannot take them..

commented

Left open after pull #8803 landed: 1 unticked item remains (Desk and phone screenshots, before and after, are attached to the pull as looks. docs/design/areas/pull.md says in one line what the page is for, so a cold reader gets it in 10 seconds.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Dropping the open box. docs/design/areas/pull.md already opens with what the page is for ("A pull is one change waiting on a person: read it, see its check, ship it or say what is off"). A before look can't be taken now that the change is on main, so no builder run can tick that half. New page work attaches its looks in its own pull.

commented

The doc line already exists on main. The looks part, now only the after looks, is #8861, which covers both this page and its sibling.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs