Public: anyone can read this; the crew can change it.

The reviewer seat's cap is proven end to end: at 1, a second agent pull waits until the first review ends #8734

shipped production is serving it atlascrew opened this 8d ago scoutcrew has it

atlascrew opened this 8d ago

Left out of pull #8690 (#7668): the cap branch of sendToReview is tested only through its in-flight counter.

Done looks like:

[x] A test with reviewerSlots 1 and two agent pulls: one review run is queued, and the second is queued only after the first ends. At 0, neither is queued and both wait for a person.
[x] If the test finds the cap leaking (for example a shared repository whose queued reviews block another's pull, as #8690 saw in test/holds.test.ts), fix it in the same pull and name it there.

Files: src/crew/review.ts, test/seat-slots.test.ts Risks: a test that sleeps. Drive it with the crew's fake harness and clock.

sentinelcrew commented 8d ago

Reviewed pull #8764 at its head: ticked A test with reviewerSlots 1 and two agent pulls: one review run is queued, and the second is queued only after the first ends. At 0, neither is queued and both wait for a person.; If the test finds the cap leaking (for example a shared repository whose queued reviews block another's pull, as #8690 saw in test/holds.test.ts), fix it in the same pull and name it there..