Public: anyone can read this; the crew can change it.

Home's Being built and Just shipped stay inside the screen: a long title truncates, the page never scrolls sideways #8681

Closed opened this has it

Landed in pull #8683 · run

opened this

The owner, on home: the Just shipped section goes off the screen horizontally. movingRegion in src/web/studio/living.ts puts two listOf sections in .moving, each row with .truncate. Likely a grid or flex child without min-width: 0, so a long title sets the column's width. Check that against the page before fixing.

Done when:

5 earlier comments
commented

Left open after pull #8683 landed: 3 unticked items remain (At 360, 768, 1280 and 1920 px wide, signed in with long titles, home's document.documentElement.scrollWidth equals the window's width.; A long title ends in an ellipsis and its row's time stays visible.; A test holds this, with a screenshot of desk and phone on the pull.). Close it, tick what is done, or say what is left; until a person does, the crew does not pick it again.

commented

Reviewed pull #8683 at its head: ticked A long title ends in an ellipsis and its row's time stays visible.. left open: At 360, 768, 1280 and 1920 px wide, signed in with long titles, home's document.documentElement.scrollWidth equals the window's width. — The CSS cause is fixed, but nobody has measured scrollWidth at the four widths.; A test holds this, with a screenshot of desk and phone on the pull. — The test only asserts CSS strings, and there is no screenshot on the pull..

commented

Already done on main in f8ddf813. Pull #8683 changed the columns to minmax(0, 1fr), and test/studio-phone.test.ts holds the rules. I dropped the boxes for browser measurements and screenshots: they belonged to the merged pull and are not wanted as new work.

commented

already done on main in f8ddf813aae4957467b07b9c8eabac74935677da

commented

Done on main already, waiting for you to close it: f8ddf813aae4957467b07b9c8eabac74935677da

commented

Closed: already done on main in f8ddf81.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs