Public: anyone can read this; the crew can change it.

A run log still shows the forge's path when the directory ends a sentence #867

shipped production is serving it opened this
opened this

Pillar: P0 Trust (umbrella #586). Found in the review of #806 (pull #806, follow-up).

stripForgeDirs (src/runs/paths.ts) strips one of the forge's own directories from a line of output only where it stands as a whole path, so that /private/var/… is never cut in the middle. A full stop counts as a path character there, so a directory that ends a sentence (wrote to /var/folders/x/work.) is left whole, and the forge's internal path shows in the run log.

  • [ ] a full stop followed by whitespace or the end of the line is a boundary: the directory is stripped and the sentence keeps its full stop (wrote to .)
  • [ ] a sibling whose name continues after the dot (/data/1/2.bak) is still left whole
  • [ ] a test for each in test/crew.test.ts (the stripForgeDirs describe)
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs