Public: anyone can read this; the crew can change it.

A branch already on the base opens no pull: 97 empty pulls in 5 minutes must not happen #8628

shipped production is serving it opened this has it

Landed in pull #8631 · 2 runs · run

opened this

Live 2026-11-02 14:47:07–14:52:14Z, on 0.7.332: pulls #8522–#8623 by scout, one every few seconds, each with the In progress body from src/crew/early.ts:129, on the branches scout/8432-settings-tokens-names-the-harness-behind and scout/8460-an-empty-atom-feed-says-when-it-was-last. Each closed within 2 s with already on the base, not landed again (src/crew/autonomy.ts:1931) and counted as landed. main took one real commit in that time, so the vitals read 125 landed in the hour and about 30 was true. Both of those issues' work had already landed (#8480 for the Atom one).

I did not find why the opens repeated. watchForPull sets done once per run, so look at what started or re-entered runs on those issues, and at what its aheadCount sees: the head is ahead of the base by commit count while its content is already on the base.

Done when:

3 earlier comments
commented

Cause found and fixed on main in b2f0f2b5, with a test: #8497's note Left open after pull #N landed is posted as the merger, so the comment route heard a person's word and queued a feedback run. That run's watcher saw its branch ahead by commits and opened a pull, the pull closed as already on the base, the run was cancelled as the pull landed, and the merge wrote the note again. Every 5 s. Seen on #8432, #8460, #8503 in 0.7.332.

Still yours here: aheadCount counting commits rather than content, so a branch already on the base opens no pull, and a pull closed as already on the base not counting as landed in the vitals or home KPIs.

commented

Left open after pull #8631 landed: 4 unticked items remain (The cause is named in the pull, with the log line or test that shows it.; A branch whose content is already on the base opens no pull, in watchForPull and in landWork, one shared test.; A pull closed as already on the base does not count as landed in the vitals (opened/landed) or on the home KPIs.; …). Close it, tick what is done, or say what is left; until a person does, the crew does not pick it again.

commented

Reviewed pull #8631 at its head: ticked The cause is named in the pull, with the log line or test that shows it.; A branch whose content is already on the base opens no pull, in watchForPull and in landWork, one shared test.; A pull closed as already on the base does not count as landed in the vitals (opened/landed) or on the home KPIs.; A test repeats the sequence and sees one pull at most..

commented

Split by the planner. Pull #8631 (4e481725) shipped every box, and sentinel ticked all four. The one thing it left out, backfilling past pulls out of the vitals, is now #8738.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs