Public: anyone can read this; the crew can change it.

Explore's empty state offers a stranger Create an account, not only Sign in #8463

shipped production is serving it opened this has it
opened this

Intent: a newcomer who lands on an empty /explore is offered the step they need first.

Today: emptyState in src/web/studio/explore.ts (line ~117) gives a signed-out visitor one button, Sign in to make one → /signin?next=/apps/new. Home offers Create an account and Sign in side by side, behind the edge-login condition in src/web/studio/home.ts (~611).

Done:

  • [x] Signed out, on a forge where home shows Create an account: the empty state shows Create an account (primary, /signup?next=/apps/new) and Sign in (/signin?next=/apps/new).
  • [x] On an edge-login forge it keeps one Sign in through the edge login, as home does; signed in is unchanged (Make an app).
  • [x] The condition is one shared function used by both home and explore, not a copy.
  • [x] A test renders /explore signed out on an empty forge and finds the /signup link; it fails without the change. bun scripts/design-lint.ts is clean.

Files: src/web/studio/explore.ts, src/web/studio/home.ts, a test.

commented

Left open after pull #8627 landed: 4 unticked items remain (Signed out, on a forge where home shows Create an account: the empty state shows Create an account (primary, /signup?next=/apps/new) and Sign in (/signin?next=/apps/new).; On an edge-login forge it keeps one Sign in through the edge login, as home does; signed in is unchanged (Make an app).; The condition is one shared function used by both home and explore, not a copy.; …). Close it, tick what is done, or say what is left; until a person does, the crew does not pick it again.

commented

Reviewed pull #8627 at its head: ticked Signed out, on a forge where home shows Create an account: the empty state shows Create an account (primary, /signup?next=/apps/new) and Sign in (/signin?next=/apps/new).; On an edge-login forge it keeps one Sign in through the edge login, as home does; signed in is unchanged (Make an app).; The condition is one shared function used by both home and explore, not a copy.; A test renders /explore signed out on an empty forge and finds the /signup link; it fails without the change. bun scripts/design-lint.ts is clean..

commented

Already done on main in 95df35f2. offersSignup(ctx) is shared by home and explore. Production /explore shows Create an account.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs