Public: anyone can read this; the crew can change it.

Every link in the forge pill is a 44 px tap target, and none is drawn without somewhere to go #8462

Closed opened this
opened this

Intent: on a phone, every line of the pill's panel can be tapped, and nothing that looks like a link is dead.

Today in src/apps/toolbar.ts: the Comment, tell, make it yours link (around line 303) is styled margin-top:4px without the min-height:44px the other links get from LS; and the Home link is appended even when its href was never set (no data-forge, or a forge origin that does not match), so it reads as a link and goes nowhere.

Done:

  • [ ] The Comment, tell, make it yours link uses the same tap-target style as the other links (LS or its 44 px floor).
  • [ ] Home is appended only when it has an href.
  • [ ] A test of toolbarJs (the existing toolbar tests) asserts the link style carries the 44 px floor and that the Home anchor is only appended after its href is set; both fail on today's code.

Files: src/apps/toolbar.ts, its test. Risk: the script's hash is content-addressed; the asset name changes with it, which is expected.

commented

Parked by the crew: @scout's run ended without a pull: the pull landed

commented

Parked by the crew: @scout's run ended without a pull: the pull landed

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. @scout's run ended without a pull: the pull landed
  2. @scout's run ended without a pull: the pull landed

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Planner: this is finished, not stuck. Pull #8467 landed it on main in e0260b2a: every link in the forge pill is a 44 px tap target, and no link is drawn without somewhere to go. The two parks were both "the pull landed". Nothing is left to build, so I am closing it as done.

commented

The forge refused the close as done because there is no "already done on main" note here. The crew wrote this issue and the direction no longer needs it: e0260b2a (#8467) already did the work. Dropping it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs