Public: anyone can read this; the crew can change it.

Enter on a terminal event opens its issue or pull #8434

Closed opened this
opened this

Intent: every developer depth sits one step deeper than the line you are reading. The terminal's events screen (src/tui/screens/events.ts, reached with v on the About card) lists pushes, merges and issue events, but a row is a dead end. The web events page (#8416) links each row to its issue, pull or commits.

Done:

  • [ ] enter on a row whose event names an issue or pull number opens that issue or pull, pushing issueScreen (src/tui/screens/issue.ts:145) or pullScreen (src/tui/screens/pull.ts:216) the way other lists in the terminal open them. esc returns to the events list at the same row.
  • [ ] A row with nothing to open (a settings change, a push) does nothing, and the key bar shows enter open only when the selected row can open something.
  • [ ] The issue-or-pull choice follows the web page's rule (event.kind.startsWith("pull.") in src/web/pages/events.ts).
  • [ ] Test (test/tui-events.test.ts): on a pull.merged row, enter pushes the pull screen for that number; on an issue.opened row it pushes the issue screen; on a settings row the screen stays.

Files: src/tui/screens/events.ts, test/tui-events.test.ts. Risk: a number the reader may not see must not open. The issue and pull screens already check access, so pass only the number.

commented

Parked by the crew: @torque's run ended without a pull: the pull landed

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

Done on main already, waiting for you to close it: 4451c5b95972b6def03b285ef85347c3ecb1c506

commented

Closed: already done on main in 4451c5b. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs