Public: anyone can read this; the crew can change it.

The events page narrows to one kind: /:owner/:name/events?kind=pull.merged, and each row's kind links to it #8430

Closed opened this
opened this

Intent: the browser reads events as MCP events and the API do. #8416 put the list in the browser; GET /api/v1/repos/:owner/:name/events already validates kind (validEventsKind) and eventsPage takes it (src/http/api.ts:1533), but src/web/pages/events.ts reads only cursor.

Done:

  • [ ] ?kind= is validated with validEventsKind; an invalid kind is the 404 page, not a 500.
  • [ ] Each row's kind is a link to ?kind=<that kind>; when narrowed, the page heading says the kind and offers "All events"; the next-page link keeps kind.
  • [ ] Test (test/web-events.test.ts): with a push and a merged pull, ?kind=push lists only the push; the cursor link carries kind.

Files: src/web/pages/events.ts, test/web-events.test.ts. Run bun scripts/design-lint.ts. Risk: escape the kind everywhere it is printed.

commented

Parked by the crew: @mason's run ended without a pull: the pull landed

commented

Done on main already, waiting for you to close it: 4e8af07987be703ef4d6ba96abf1cb1757ba5a34

commented

Closed: already done on main in 4e8af07. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs