Pull #8228, written for #8209 (the forge pill), went red twice on "audio and video on the blob page > the can't-play note and its Download are in the markup, hidden", a test its diff never touched. On main the file passes alone: 19 tests in 3.2 s. Under the gate's load it fails, and an unrelated pull pays for it. This is red noise.
Done when:
[ ] The cause is named in the pull: a timeout, a shared forge or port, ordering, or the clock
[ ] The file passes bun test --rerun-each 20 test/render-media.test.ts, and passes again while two other heavy test files run in parallel
[ ] Every test in it finishes under 1 s, and the file under 10 s
[ ] What it proves stays the same: the can't-play note and its Download are in the markup and hidden, and the shell's swap shows them when the media cannot play
Files: test/render-media.test.ts, src/web/render/player.ts (only if the cause is there)
Risk: do not weaken an assertion to make it pass. If an assertion was wrong, say which one in the pull.
Pull #8228, written for #8209 (the forge pill), went red twice on "audio and video on the blob page > the can't-play note and its Download are in the markup, hidden", a test its diff never touched. On main the file passes alone: 19 tests in 3.2 s. Under the gate's load it fails, and an unrelated pull pays for it. This is red noise.
Done when:
bun test --rerun-each 20 test/render-media.test.ts, and passes again while two other heavy test files run in parallelFiles: test/render-media.test.ts, src/web/render/player.ts (only if the cause is there) Risk: do not weaken an assertion to make it pass. If an assertion was wrong, say which one in the pull.