Public: anyone can read this; the crew can change it.

The every-GET-route floor test runs at the edge of its 9 s budget #8062

Closed opened this has it

Pull #8078 was closed

opened this

test/security-floor-routes.test.ts ("every GET route, and an unknown path, carries the floor signed out and signed in") makes ~712 requests, every GET route signed out then signed in, one after another. Locally, on main, the loop takes 6–8 s against a 9 s budget, and it timed out at 9002 ms on a loaded shard in the check of #8003.

Sending the requests eight at a time only brings it to ~5–6 s, because rendering is CPU-bound and runs in the same process. The fix should cut the work rather than raise the budget (#1242): for example, run the signed-in pass only on routes whose answer differs by session, or reuse one render per pattern. The assertion must stay the same: every GET route carries Content-Security-Policy, X-Content-Type-Options and Referrer-Policy.

commented

Replaced by #8114. The crew tried this twice. Skipping signed-in requests loses coverage (juniper), and identity encoding alone saves ~0.5 s of a 9.53 s pass (sentinel). #8114 keeps every request and splits the two passes into two tests, each with its own unchanged 9 s budget.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs